actions-on-google / assistant-conversation-nodejs

A developer friendly way to fulfill Actions SDK handlers for the Google Assistant
https://actions-on-google.github.io/assistant-conversation-nodejs
Apache License 2.0
104 stars 38 forks source link

Dynamic transition of scenes has broken #43

Open Topias-Pratsam opened 3 years ago

Topias-Pratsam commented 3 years ago

Dynamic transition of scenes has broken. Only transitions done in action builder work. Any transitions done in webhook are not registering. https://developers.google.com/assistant/conversational/webhooks?tool=builder#transition_scenes

This was still working last week. Even older systems that have been properly tested have broken. Maybe the error has something to do with recent updates to assistant devices?

Topias-Pratsam commented 3 years ago

Today it seems like the dynamic transition works in simulator, but not with Nest Hub or Google Home device. Yesterday it didn't work even in simulator.

Topias-Pratsam commented 3 years ago

This is a critical bug that is completely ruining our user experience, is there a way to send this to firmware Action builder team fast?

Some information:

Three examples, after dynamically transitioning new scene that has an intent which wasn't in old scene:

  1. Half way scene transition: Sometimes the error is "Did not find any handling for intent event 'intentOfNewScene' on scene 'OldScene'". which suggests that intentOfNewScene was triggered by users phrase but it could not be handled since AoG still thinks that we are in "OldScene" even thou "intentOfNewScene" does not exist on OldScene and should not be able to trigger from there.

  2. No transition at all Sometimes the the action on google just answers with fallback response as if the transition to new scene didn't happen at all.

  3. Rare successful transition Sometimes the dynamic transition does work.

Fleker commented 3 years ago

Hey is there a case that I can reproduce? Does this happen with any sample projects? Is there an Actions SDK project you can provide as a zip?

Topias-Pratsam commented 3 years ago

The dynamic transition is not used in sample projects. I made small project that has also has the required code for inline webhook. (see attachments) Also added a picture of the error in actions console test. In the picture you can see the how scene is changing back.

What i found out while making this:

And if a breaking update is coming it would be nice to get a warning email before hand, so that we would have time to fix it. Could a mailing list for new updates be added eventually? Also it would be nice to be able to test new updates to make sure they are not breaking our production.

scenebug

debugging_scenebug.zip

Fleker commented 3 years ago

Thank you for putting this together. I've reproduced your error and have passed it to the team.