search

actions-on-google / assistant-conversation-testing-nodejs

Assistant conversation testing library
Apache License 2.0
21 stars 16 forks source link

Firebase Terms of Service is not accepted. Navigate to your project's overview page on the Actions Console to accept the Terms of Service #4

Open panaC opened 3 years ago

panaC commented 3 years ago 
1) Test Suite
       "before all" hook: Before all setup for "trigger only test":
     Error: 9 FAILED_PRECONDITION: Firebase Terms of Service is not accepted. Navigate to your project's overview page on the Actions Console to accept the Terms of Service.
      at Object.callErrorFromStatus (node_modules/@grpc/grpc-js/build/src/call.js:31:26)
      at Object.onReceiveStatus (node_modules/@grpc/grpc-js/build/src/client.js:244:52)
      at Object.onReceiveStatus (node_modules/@grpc/grpc-js/build/src/client-interceptors.js:336:141)
      at Object.onReceiveStatus (node_modules/@grpc/grpc-js/build/src/client-interceptors.js:299:181)
      at /home/pierre/Documents/edrlab/audiobooks/audiobooks/test/node_modules/@grpc/grpc-js/build/src/call-stream.js:145:78
      at processTicksAndRejections (internal/process/task_queues.js:75:11)

any idea how to solve this issue ?


import 'mocha';

import {ActionsOnGoogleTestManager} from '@assistant/conversation-testing';

const DEFAULT_LOCALE = 'en-US';
const DEFAULT_SURFACE = 'PHONE';

const PROJECT_ID = 'audiobooks-a';
const TRIGGER_PHRASE = 'Parler avec audiobooks';

describe('Test Suite', function () {
  // Set the timeout for each test run to 60s.
  this.timeout(60000);
  let testManager: ActionsOnGoogleTestManager;

  before('Before all setup', async () => {
    testManager = new ActionsOnGoogleTestManager({projectId: PROJECT_ID});
    await testManager.writePreviewFromDraft();
    testManager.setSuiteLocale(DEFAULT_LOCALE);
    testManager.setSuiteSurface(DEFAULT_SURFACE);
  });

  it('trigger only test', async () => {
    await testManager.sendQuery(TRIGGER_PHRASE);
    testManager.assertIntent('actions.intent.MAIN');
    // testManager.assertScene('Welcome');
    // testManager.assertSpeech('Welcome to Facts about Google!');
  });

  afterEach('post test cleans', async () => {
    testManager.cleanUpAfterTest();
  });
});
mandelbroo commented 3 years ago

Same issue

> env GOOGLE_APPLICATION_CREDENTIALS=./handler/tests/e2e/credentials.json jest --env=node --detectOpenHandles --globalSetup=./handler/tests/e2e/global-setup.js ./handler/tests/e2e/

Determining test suites to run...Starting writePreview From Draft
Error: 9 FAILED_PRECONDITION: Firebase Terms of Service is not accepted. Navigate to your project's overview page on the Actions Console to accept the Terms of Service.
    at Object.callErrorFromStatus (node_modules/@grpc/grpc-js/build/src/call.js:31:26)
    at Object.onReceiveStatus (node_modules/@grpc/grpc-js/build/src/client.js:244:52)
    at Object.onReceiveStatus (node_modules/@grpc/grpc-js/build/src/client-interceptors.js:336:141)
    at Object.onReceiveStatus (node_modules/@grpc/grpc-js/build/src/client-interceptors.js:299:181)
    at node_modules/@grpc/grpc-js/build/src/call-stream.js:130:78
    at processTicksAndRejections (internal/process/task_queues.js:79:11)
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! google-assistant-actions-handler@0.1.0 test-e2e: `env GOOGLE_APPLICATION_CREDENTIALS=./handler/tests/e2e/credentials.json jest --env=node --detectOpenHandles --globalSetup=./handler/tests/e2e/global-setup.js ./handler/tests/e2e/`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the google-assistant-actions-handler@0.1.0 test-e2e script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     .npm/_logs/2021-03-09T10_12_31_000Z-debug.log
leowilbur commented 3 years ago

Hi @omohayui @mandelbroo @taycaldwell Could you help me to check this issue? Thank you in advance

omohayui commented 3 years ago

I also got the same error when running the test.

And I have confirmed that the same error is returned when I request the writePreview method in Actions API from the client library.

(node:16712) UnhandledPromiseRejectionWarning: Error: 9 FAILED_PRECONDITION: Firebase Terms of Service is not accepted. Navigate to your project's overview page on the Actions Console to accept the Terms of Service.

But no terms to accept are found in my Actions Console. Has anything changed inside Actions on Google?

pglejzer commented 3 years ago

did someone fix this problem?

luca-nardelli-memori commented 3 years ago

Same problem here

omohayui commented 3 years ago

I'm also still having the same problem and asking about it from GCP support cases.

luca-nardelli-memori commented 3 years ago

I contacted via mail some Google Developers Experts for Google Assistant

https://developers.google.com/assistant/community/gde

pglejzer commented 3 years ago

I think the problem is with writePreviewFromDraft()/ writePreviewFromVersion(). If I remove that part the tests are going and that error disappeared but it will fail from 'sendQuery' with the error ' Error: sendInteraction API call failed: Error: 3 INVALID_ARGUMENT: Interaction did not trigger the preview of an action.'.

yoichiro commented 3 years ago

Hi there! I'm one of Assistant GDEs. Luca, thank you for the report, we got your email. I have already reported this issue to the team of Google, and I heard that they're investigating about it. I intend to post a comment here after receiving the feedback from the team.

pglejzer commented 3 years ago

I think it is working now. My tests passed. @yoichiro Thanks!

omohayui commented 3 years ago

I also confirmed it has fixed! Thanks a lot!

leowilbur commented 3 years ago

It is working. Thank you in advance :) Great job

atulep commented 3 years ago

Hi everyone,

Thank you for reporting this. We rolled out a fix for this issue, and it should be working now.

I'm closing this issue, but feel free to reopen should the issue come up again.

panaC commented 3 years ago

thanks everyone :+1:

luca-nardelli-memori commented 3 years ago

Thanks a lot!!!

luca-nardelli-memori commented 3 years ago

The problem is here again !!

Error: 9 FAILED_PRECONDITION: Firebase Terms of Service is not accepted. Navigate to your project's overview page on the Actions Console to accept the Terms of Service.

@atulep

omohayui commented 3 years ago

Are you still having the error? I can't get the error now.

luca-nardelli-memori commented 3 years ago

I confirm I still have the error @omohayui

luca-nardelli-memori commented 3 years ago

Hi everyone,

Thank you for reporting this. We rolled out a fix for this issue, and it should be working now.

I'm closing this issue, but feel free to reopen should the issue come up again.

Hello, the problem is still here..

atulep commented 3 years ago

Hello,

Thanks for reporting this. We did some changes to the API; however, e2e testing went fine, and I can't reproduce this issue now too.

Did you use the same setup & code as in https://github.com/actions-on-google/assistant-conversation-testing-nodejs/issues/4#issue-820519888? Also, does it also fail after:

Determining test suites to run...
Starting writePreview From Draft

?

luca-nardelli-memori commented 3 years ago

Did you use the same setup & code as in #4 (comment)? Also, does it also fail after:

To be honest I'm using this project: https://github.com/actions-on-google/assistant-conversation-nodejs

20 days ago, when the problem was resolved here, it was resolved also in the project "assistant-conversation-nodejs"

luca-nardelli-memori commented 3 years ago

@atulep could you please tell me which changes did you make to the API, so I can propose pull request in the assistant-conversation-nodejs project ?

atulep commented 3 years ago

Did you use the same setup & code as in #4 (comment)? Also, does it also fail after:

To be honest I'm using this project: https://github.com/actions-on-google/assistant-conversation-nodejs

20 days ago, when the problem was resolved here, it was resolved also in the project "assistant-conversation-nodejs"

If you still experience this error, can you go to the Actions on Google Console and try to accept Terms of Service?

@atulep could you please tell me which changes did you make to the API, so I can propose pull request in the assistant-conversation-nodejs project ?

The change didn't affect the frontend of the API. Sorry for confusion.

luca-nardelli-memori commented 3 years ago

can you go to the Actions on Google Console and try to accept Terms of Service?

Unfortunately no, because there is not a checkbox where to accept the terms :-(

The change didn't affect the frontend of the API. Sorry for confusion.

Ok, so the fix was applied to the backend ?

atulep commented 3 years ago

Apologies for delayed reply.

can you go to the Actions on Google Console and try to accept Terms of Service?

Unfortunately no, because there is not a checkbox where to accept the terms :-(

Hm, this doesn't sound right. Can you please describe your setup?

The change didn't affect the frontend of the API. Sorry for confusion.

Ok, so the fix was applied to the backend ?

Yes.

luca-nardelli-memori commented 3 years ago

Can you please describe your setup?

There is not any checkbox where to accept the requested terms...I searched everywhere

mishushakov commented 3 years ago

I'm having the issue but with @assistant/actions package https://github.com/actions-on-google/assistant-actions-nodejs/issues/2