search

actions-rs / audit-check

🛡️ GitHub Action for security audits
https://github.com/marketplace/actions/rust-audit-check
MIT License
170 stars 39 forks source link

Fallback to stdout report for forks #104

Closed ordian closed 4 years ago

ordian commented 4 years ago

Please implement the same workaround for audit-check as you did for clippy.

ordian commented 4 years ago

I think it's mostly implemented and lacking a return statement for else branch here https://github.com/actions-rs/audit-check/blob/69fdbe9b61b75ba374c275c34559b56a8b9c643d/src/reporter.ts#L152-L156 @svartalf could you confirm?

svartalf commented 4 years ago

I would expect it to work already, just a line above from your snippet:

https://github.com/actions-rs/audit-check/blob/69fdbe9b61b75ba374c275c34559b56a8b9c643d/src/reporter.ts#L151

Do you have an example where it does not work as expected?

ordian commented 4 years ago

https://github.com/openethereum/openethereum/runs/562748013

ordian commented 4 years ago

It uses audit-check@v1 https://github.com/openethereum/openethereum/blob/master/.github/workflows/audit.yml

ordian commented 4 years ago

(This issue is about exiting successfully if in a fork with no errors)

ordian commented 4 years ago

I've noticed your branch https://github.com/actions-rs/audit-check/tree/issue-104, are there any updates?

svartalf commented 4 years ago

@ordian yeah, I'm working on it.