actions-rs / clippy-check

📎 GitHub Action for PR annotations with clippy warnings
https://github.com/marketplace/actions/rust-clippy-check
MIT License
287 stars 40 forks source link

Annotations fail on jobs with multiple targets #138

Open andrewbanchich opened 3 years ago

andrewbanchich commented 3 years ago

Workflow file:

on:
  pull_request:
    branches: [ master ]

name: Clippy
jobs:
  rustfmt:
    runs-on: ubuntu-latest
    continue-on-error: true
    steps:
      - uses: actions/checkout@v2
      - run: rustup component add rustfmt
      - run: cargo fmt -- --check

  clippy_check:
    runs-on: ${{ matrix.os }}
    strategy:
      matrix:
        os: [windows-2019, ubuntu-latest]
    steps:
      - uses: actions/checkout@v2
      - uses: actions-rs/toolchain@v1
        with:
            toolchain: nightly
            components: clippy

      - uses: actions-rs/clippy-check@v1
        env:
          SQLX_OFFLINE: true
        with:
          token: ${{ secrets.GITHUB_TOKEN }}
          args: --all-features -- -D warnings

This will create annotations for the first completed Clippy check, but any others will never finish.

Screenshot_20210417-092702~2 Screenshot_20210417-092713~2