actions-rs / clippy-check

📎 GitHub Action for PR annotations with clippy warnings
https://github.com/marketplace/actions/rust-clippy-check
MIT License
287 stars 40 forks source link

Clippy action not properly reporting ICEs #161

Open PyroTechniac opened 2 years ago

PyroTechniac commented 2 years ago

(Accidentally opened this on the wrong repo)

Do the checklist before filing an issue:

Description

My current workflow has encountered an ICE, however, the clippy action doesn't acknoledge it as one in the generated report

Workflow code

Paste that part of your workflow yaml file that causes the bug in here.
  clippy:
    name: Clippy
    runs-on: ubuntu-latest

    steps:
      - name: Checkout sources
        uses: actions/checkout@v2

      - name: Install nightly toolchain
        id: toolchain
        uses: actions-rs/toolchain@v1
        with:
          toolchain: nightly
          components: clippy
          profile: minimal
          override: true

      - name: Cache dependencies
        uses: Swatinem/rust-cache@v1

      - name: Run clippy
        uses: actions-rs/clippy-check@v1
        env:
          RUSTFLAGS: "-C target-cpu=haswell"
        with:
          token: ${{ secrets.GITHUB_TOKEN }}
          args: --all-features --tests --workspace

Action output

  thread 'rustc' panicked at 'assertion failed: self.start_pos.to_u32() + total_extra_bytes <= bpos.to_u32()', compiler/rustc_span/src/lib.rs:1677:9
  note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

  error: internal compiler error: unexpected panic

  note: the compiler unexpectedly panicked. this is a bug.

  note: we would appreciate a bug report: https://github.com/rust-lang/rust-clippy/issues/new

  note: Clippy version: clippy 0.1.58 (65f3f8b 2021-11-21)

  query stack during panic:
  #0 [analysis] running analysis passes on this crate
  end of query stack
  {"reason":"compiler-message","package_id":"starchart 0.4.0 (path+file:///home/runner/work/starchart/starchart)","manifest_path":"/home/runner/work/starchart/starchart/Cargo.toml","target":{"kind":["lib"],"crate_types":["lib"],"name":"starchart","src_path":"/home/runner/work/starchart/starchart/src/lib.rs","edition":"2018","doc":true,"doctest":true,"test":true},"message":{"rendered":"warning: 9 warnings emitted\n\n","children":[],"code":null,"level":"warning","message":"9 warnings emitted","spans":[]}}
  ##[debug]Message code is missing, ignoring it
  {"reason":"build-finished","success":false}
  ##[debug]Unexpected reason field, ignoring it: build-finished
  error: could not compile `starchart`; 10 warnings emitted
  ::endgroup::
Clippy results: 0 ICE, 0 errors, 9 warnings, 0 notes, 0 help
##[debug]Prepared next annotations bucket, 9 size
##[debug]This is a last iteration, marking check as "completed", conclusion: success
##[debug]Prepared next annotations bucket, 0 size
Error: Clippy had exited with the 101 exit code
##[debug]Node Action run completed with exit code 1
##[debug]Finishing: Run clippy

Expected behavior

The clippy report generated to have a one when reporting ICEs

Additional context

Add any other context about the problem here. logs_1030.zip