actions-rs / clippy

WIP
MIT License
8 stars 5 forks source link

clippy does not show as failed in workflow #2

Open ignatenkobrain opened 4 years ago

ignatenkobrain commented 4 years ago

Do the checklist before filing an issue:

Description

When clippy exits with an error, github workflow is not marked as failed. I think it is not issue with github actions, but I am new to all this and can't judge.

image

Workflow code

https://github.com/ignatenkobrain/zram-generator/blob/9089c94cd416de95faaff0eab9027b5ee90b7365/.github/workflows/ci.yml#L59-L75

Action output

Executing cargo clippy (JSON output)
Clippy exited with 101 code

If I understand code correctly, it just captures return code and always returns 0 unless there is some exception happened in the typescript.

Expected behavior

I am not sure if return code should be compared to 101 or anything else, just would like to make sure that CI blocks on clippy showing any errors.