search

actions-rs / meta

🦀 GitHub Actions for Rust - recipes, discussions, questions and ideas
https://github.com/actions-rs
Creative Commons Zero v1.0 Universal
353 stars 15 forks source link

Clippy is installed by default #10

Closed b1zzu closed 4 years ago

b1zzu commented 4 years ago

We can remove rustup component add clippy from the example because it's installed by default

svartalf commented 4 years ago

Hi, @b1zzu, thank you for a contribution! I'm kinda against this change because:

  1. clippy is not installed by default at the macOS environments: 
    /Users/runner/.cargo/bin/cargo clippy -- -D warnings
error: 'cargo-clippy' is not installed for the toolchain 'stable-x86_64-apple-darwin'
  2. It is also not installed for nightly toolchains, so it would be unclear why it is either available or not, depending on some random factors.

Considering that calling rustup component add clippy is really cheap if clippy is installed already, I would leave that as is until the #12 will be resolved.