search

actions-rs / meta

🦀 GitHub Actions for Rust - recipes, discussions, questions and ideas
https://github.com/actions-rs
Creative Commons Zero v1.0 Universal
353 stars 15 forks source link

add workspace and all-targets to recipes #27

Open koivunej opened 4 years ago

koivunej commented 4 years ago

rationale: if someone just copies and pastes the recipes over, the --workspace and --all-targets should do no harm but also will not cause surprises when user adds an subcrate. The user might not want to have all of their test code ran through clippy, so they might choose to just use --examples --bins --benches for example. building and testing the workspace doesn't seem to cause issues in crates without a workspace.

this brings the configuration to more in line with cargo fmt --all ..., which does work on all of the workspace.

I haven't used the auditor one so can't comment if it should have some --workspace switch as well though it's configuration doesn't seem to hint at it.

vmx commented 4 years ago

I was about to propose the a similar change. Are there any reasons for not merging it?