feature request: support `rust-toolchain.toml` files

actions-rust-lang / setup-rust-toolchain

Setup a specific Rust toolchain with extra features like problem matchers

MIT License

193 stars 33 forks source link

Closed smallstepman closed 2 years ago

smallstepman commented 2 years ago

detect if rust-toolchain or rust-toolchain.toml files are present at the root dir of the repo https://rust-lang.github.io/rustup/overrides.html#the-toolchain-file
install rust version, targets, components
add option to set them as defaults

jonasbb commented 2 years ago

This should do the trick.

if [ -f "rust-toolchain.toml" ]; then
    rustup show
fi

rustup show might not work forever (https://github.com/rust-lang/rustup/issues/1397) but I don't know of a better way.

I don't know what you mean with your last point. A toolchain file should always take priority over the default toolchain (via rustup default).

smallstepman commented 2 years ago

Nice! a.d. last point - I imagined it possible to be able to stay

I do have rust-toolchain.toml, but I don’t want to use it

sorry for that last point being very unclear 😅

in the end, I don’t find it being a crucial feature to have