Webhook Based horizontalrunnerautoscaler can't use Additional Autoscaling Prometheus Metrics

[newdeal123]

Checks

• [X] I've already read https://github.com/actions/actions-runner-controller/blob/master/TROUBLESHOOTING.md and I'm sure my issue is not covered in the troubleshooting guide.
• [X] I'm not using a custom entrypoint in my runner image

Controller Version

0.27.4

Helm Chart Version

0.23.3

CertManager Version

1.7.1

Deployment Method

Helm

cert-manager installation

I installed cert-manager correctly by helm (v1.7.1)

Checks

• [X] This isn't a question or user support case (For Q&A and community support, go to Discussions. It might also be a good idea to contract with any of contributors and maintainers if your business is so critical and therefore you need priority support
• [X] I've read releasenotes before submitting this issue and I'm sure it's not due to any recently-introduced backward-incompatible changes
• [X] My actions-runner-controller version (v0.x.y) does support the feature
• [X] I've already upgraded ARC (including the CRDs, see charts/actions-runner-controller/docs/UPGRADING.md for details) to the latest and it didn't fix the issue
• [X] I've migrated to the workflow job webhook event (if you using webhook driven scaling)

Resource Definitions

apiVersion: actions.summerwind.dev/v1alpha1
kind: HorizontalRunnerAutoscaler
metadata:
  namespace: github-actions
  name: github-actions-hra
spec:
  minReplicas: 1
  maxReplicas: 20
  scaleTargetRef:
    kind: RunnerDeployment
    name: github-actions-runner
  scheduledOverrides:
  - startTime: "2023-07-26T00:00:00Z"
    endTime: "2023-07-26T12:00:00Z"
    recurrenceRule:
      frequency: Daily
    minReplicas: 2
  scaleUpTriggers:
    - githubEvent:
        workflowJob: {}
      duration: "60m"

To Reproduce

1. set `metrics.serviceMonitor.enabled` to `true`, `actionsMetricsServer.enabled` to `true`
2. install helm chart
3. check prometheus dashboard
4. can see only 3 HorizontalRunnerAutoscaler metrics.

Describe the bug

at first, I see this discussions.

I expected various promethus metrics for hra (because this PR is merged) , but I can see only 3 metrics. This means that the newly added 10 metric was not visible.

Looking at the discussion history, it seems that there are many users who experience the same issues as me.

https://github.com/actions/actions-runner-controller/blob/dcb64f0b9e889f4751bf257f2a37632ce10a3e10/controllers/actions.summerwind.net/autoscaling.go#L51-L58

After reviewing the internal code, it is determined that additional metrics are not available for webhook based hra.

Describe the expected behavior

Support Webhook Based horizontalrunnerautoscaler to use Additional Autoscaling Prometheus Metrics

• horizontalrunnerautoscaler_replicas_desired
• horizontalrunnerautoscaler_runners
• horizontalrunnerautoscaler_runners_registered
• horizontalrunnerautoscaler_runners_busy
• horizontalrunnerautoscaler_terminating_busy
• horizontalrunnerautoscaler_necessary_replicas
• horizontalrunnerautoscaler_workflow_runs_completed
• horizontalrunnerautoscaler_workflow_runs_in_progress
• horizontalrunnerautoscaler_workflow_runs_queued
• horizontalrunnerautoscaler_workflow_runs_unknown

Whole Controller Logs

.

Whole Runner Pod Logs

.

Additional Context

No response

[github-actions[bot]]

Hello! Thank you for filing an issue.

The maintainers will triage your issue shortly.

In the meantime, please take a look at the troubleshooting guide for bug reports.

If this is a feature request, please review our contribution guidelines.

[fralvarop]

Same issue here. Any plans on fixing it?

[m-perrott]

Same issue here.

[sawyerward]

I am experiencing the same issue.