search

actions / actions-runner-controller

Kubernetes controller for GitHub Actions self-hosted runners
Apache License 2.0
4.76k stars 1.13k forks source link

support multiple repositories with array in crd RunnerDeployment #3029

Open Rosyya opened 1 year ago

Rosyya commented 1 year ago

What would you like added?

in RunnerDeployment there is a general requirement to support multiple repository since it's more safe than organization level, but from current crd description https://github.com/actions/actions-runner-controller/blob/master/charts/actions-runner-controller/crds/actions.summerwind.dev_runnerdeployments.yaml#L3366, only string type is supported, we need to create multiple RunnerDeployment to add different repository instead of add a array in one RunnerDeployment spec. is that ok to update repository string type to repositories array type？

Note: Feature requests to integrate vendor specific cloud tools (e.g. awscli, gcloud-sdk, azure-cli) will likely be rejected as the Runner image aims to be vendor agnostic.

Why is this needed?

A clear and concise description of any alternative solutions or features you've considered.

Additional context

Add any other context or screenshots about the feature request here.

github-actions[bot] commented 1 year ago

Hello! Thank you for filing an issue.

The maintainers will triage your issue shortly.

In the meantime, please take a look at the troubleshooting guide for bug reports.

If this is a feature request, please review our contribution guidelines.