Open thomassandslyst opened 11 months ago
Hello! Thank you for filing an issue.
The maintainers will triage your issue shortly.
In the meantime, please take a look at the troubleshooting guide for bug reports.
If this is a feature request, please review our contribution guidelines.
Checks
Controller Version
0.6.1
Deployment Method
ArgoCD
Checks
To Reproduce
Describe the bug
"runnerScaleSetName" (defined as "gha-runner-scale-set.scale-set-name" in _helpers.tpl) is tightly bound to several values in the metadata including resource names, this limits the Github Actions label resulting from this to the k8s' RFC 1123 naming scheme which restricts it to lower case only and no underscores.
This is troublesome as many descriptive labels, such as architectures, contain capital letters or underscores such as "x86_64".
I suggest decoupling runnerScaleSetName and instead relying on "gha-runner-scale-set.name" in _helpers.tpl which should be set by the helm release name or by a separate name value.
Describe the expected behavior
"runnerScaleSetName" should be able to be set in the helm chart to any combination of characters supported by Github Actions.
Additional Context
Controller Logs
Runner Pod Logs