When starting gha-runner-scale-set in "dind" mode, I would like to be able to change the Dockerd settings in the Pod using the values.yaml.

t-matsu200 commented 3 months ago

What would you like added?

When gha-runner-scale-set is started in "dind" mode, I would like to be able to change the proxy settings and insecure-registry settings for Dockerd on the Pod from values.yaml.

Why is this needed?

When starting gha-runner-scale-set in "dind" mode behind a proxy server, it was not possible to retrieve container images from the internet when running GitHub Actions workflows. Additionally, it was not possible to retrieve images from container registries with self-certificates applied. If I modify the settings of "gha-runner-scale-set.dind-container" appropriately, it will behave as expected. I would like to be able to change proxy settings and insecure-registry settings without having to perform these workarounds.

Actually, I modified the following parts and started gha-runner-scale-set.

◆Added "HTTP_PROXY", "HTTPS_PROXY" and "NO_PROXY" https://github.com/actions/actions-runner-controller/blob/master/charts/gha-runner-scale-set/templates/_helpers.tpl#L104-L106

◆Mount ConfigMap to "/etc/docker/daemon.json" https://github.com/actions/actions-runner-controller/blob/master/charts/gha-runner-scale-set/templates/_helpers.tpl#L109-L115

Additional context

Add any other context or screenshots about the feature request here.

github-actions[bot] commented 3 months ago

Hello! Thank you for filing an issue.

The maintainers will triage your issue shortly.

In the meantime, please take a look at the troubleshooting guide for bug reports.

If this is a feature request, please review our contribution guidelines.

Hazmi35 commented 2 months ago

I need to modify dockerd args on dind container, turns out it is not templated and is hardcoded directly at https://github.com/actions/actions-runner-controller/blob/1987d9eb2ed60b8164bde872ea61b159582ceb40/charts/gha-runner-scale-set/templates/_helpers.tpl#L98-L116

Hazmi35 commented 2 months ago

I need to modify dockerd args on dind container, turns out it is not templated and is hardcoded directly at

https://github.com/actions/actions-runner-controller/blob/1987d9eb2ed60b8164bde872ea61b159582ceb40/charts/gha-runner-scale-set/templates/_helpers.tpl#L98-L116

cc @nikola-jokic. I apologize for the mention, but as you are one of the maintainers who frequently commits here.

This issue is labeled community but the author clearly states this is for gha-runner-scale-set. It is kinda confusing where to report bug and or feature request regarding helm charts for gha-runner-scale-set.

I am not even sure if this is a feature request or a bug because is this intended or something that need to be addressed? I see that there's also PR related to this issue: https://github.com/actions/actions-runner-controller/pull/3394

nikola-jokic commented 2 months ago

Hey everyone,

@Hazmi35 you are right, this one is for the gha-runner-scale-set. Feature requests related to the gha-runner-scale-set should be submitted to the GitHub Community Support Forum:

That being said, we documented that:

To customize the spec, comment out or remove containerMode, and append the configuration you want in the template section.

It should be easy since we documented the exact setup in values.yaml file that would be used for that container mode. I will close this issue here. :relaxed:

actions / actions-runner-controller