AutoscalingRunnerSet not accepting tolerations for the listener

cyber-kamil commented 2 months ago

Checks

[X] I've already read https://docs.github.com/en/actions/hosting-your-own-runners/managing-self-hosted-runners-with-actions-runner-controller/troubleshooting-actions-runner-controller-errors and I'm sure my issue is not covered in the troubleshooting guide.
[X] I am using charts that are officially provided

Controller Version

0.9.0

Deployment Method

Helm

Checks

[X] This isn't a question or user support case (For Q&A and community support, go to Discussions).
[X] I've read the Changelog before submitting this issue and I'm sure it's not due to any recently-introduced backward-incompatible changes

To Reproduce

Setting values for the helm chart of ghcr.io/actions/actions-runner-controller-charts/gha-runner-scale-set 

listenerTemplate:
  spec:
    containers:
    - name: listener
      tolerations:
      - key: "node-taints.xxxxx"
        value: "app"
        operator: "Equal"
        effect: "NoSchedule"

Describe the bug

When trying to create the runner scale set and trying to set pod tolerations in the listenerTemplate as specified in the documentation the values are not picked up by the listener pods having looked over the definition of AutoscalingRunnerSet it's clear that they aren't picked up. Having looked over the templates it's clear that any tolerations are missing as well as node affinity or anything allowing you to select where the pods are supposed to be created:

https://github.com/actions/actions-runner-controller/blob/master/charts/gha-runner-scale-set/templates/autoscalingrunnerset.yaml

Describe the expected behavior

When setting those values pods should have those tolerations created on them.

Additional Context

Having a setup where every node has some sort of a taint it's nearly impossible to create the AutoscailingRunnerSet as the listeners can't be created.

Controller Logs

2024-04-09T23:27:12Z    INFO    AutoscalingListener Created listener pod    {"autoscalinglistener": {"name":"arc-runner-set-754b578d-listener","namespace":"arc-systems"}, "namespace": "arc-systems", "name": "arc-runner-set-754b578d-listener"}

Runner Pod Logs

Creates them correctly however the pods have an error of: Failed to schedule pod, incompatible with nodepool "xxxx",

github-actions[bot] commented 2 months ago

Hello! Thank you for filing an issue.

The maintainers will triage your issue shortly.

In the meantime, please take a look at the troubleshooting guide for bug reports.

If this is a feature request, please review our contribution guidelines.

cyber-kamil commented 2 months ago

https://github.com/actions/actions-runner-controller/issues/3265 this seems to fix the issue

actions / actions-runner-controller