ServiceMonitor missing?

actions / actions-runner-controller

Kubernetes controller for GitHub Actions self-hosted runners

Apache License 2.0

4.4k stars 1.04k forks source link

ServiceMonitor missing? #3525

Closed marekaf closed 1 month ago

marekaf commented 1 month ago

ServiceMonitor is missing in chart templates for the new controller even though a helper is mentioning it https://github.com/actions/actions-runner-controller/blob/a6d87c46cd01d5ded0c547793ead736fbdd47061/charts/gha-runner-scale-set-controller/templates/_helpers.tpl#L130

Are ServiceMonitor and Prometheus metrics supported in the new controller?

github-actions[bot] commented 1 month ago

Hello! Thank you for filing an issue.

The maintainers will triage your issue shortly.

In the meantime, please take a look at the troubleshooting guide for bug reports.

If this is a feature request, please review our contribution guidelines.

marekaf commented 1 month ago

@nikola-jokic but this is a feature request, I want that Service Monitor :D

nikola-jokic commented 1 month ago

Hey @marekaf,

Feature requests for gha-runner-scale-set should be submitted to the Community Support Forum. I would normally close this issue with this message, but you provided enough information so I wanted to close it with the PR and write a message later. Sorry I didn't write the message sooner...