Remove finalizers in one pass to speed up cleanups AutoscalingRunnerSet

actions / actions-runner-controller

Kubernetes controller for GitHub Actions self-hosted runners

Apache License 2.0

4.76k stars 1.12k forks source link

Remove finalizers in one pass to speed up cleanups AutoscalingRunnerSet #3536

Closed nikola-jokic closed 6 months ago

nikola-jokic commented 6 months ago

When you create a faulty autoscaling runner set, for example token is not correct, the cleanup will be very slow. This PR removes the requeue (probably many events are raised causing latency, I'm not sure), so autoscaling runner set, and dependent resources can be removed much more quickly.

Fixes: #3512 Fixes: #3497