Open Runner scale set runner dind image to config

actions / actions-runner-controller

Kubernetes controller for GitHub Actions self-hosted runners

Apache License 2.0

4.77k stars 1.13k forks source link

Open Runner scale set runner dind image to config #3547

Closed zongsizhang closed 6 months ago

zongsizhang commented 6 months ago

What would you like added?

As of v0.9.2, the helm chart charts/gha-runner-scale-set still hardcodes the DinD container specifications. It will be helpful if we can open the dind container to be configurable.

Why is this needed?

My company needs to run some CI/CD tasks on GPU machines. We need to use the image below instead of the default dind image.

I'd be very happy to contribute if you find this case make sense

https://github.com/Extrality/nvidia-dind

github-actions[bot] commented 6 months ago

Hello! Thank you for filing an issue.

The maintainers will triage your issue shortly.

In the meantime, please take a look at the troubleshooting guide for bug reports.

If this is a feature request, please review our contribution guidelines.

nikola-jokic commented 6 months ago

Hey @zongsizhang,

We are aware of this need to customize container modes through values.yaml, but currently, we decided on documenting how to apply modifications here.

This issue is related to gha-runner-scale-set, and therefore, should be submitted to the GitHub Community Support Forum.