search

actions / actions-runner-controller

Kubernetes controller for GitHub Actions self-hosted runners
Apache License 2.0
4.76k stars 1.12k forks source link

Support --no-default-labels runner configuration option #3622

Open scoplin opened 5 months ago

scoplin commented 5 months ago

What would you like added?

Support for removing the default labels from a runner was added in https://github.com/actions/runner/pull/2443. This takes the form of an additional flag being passed to config.sh.

It appears that there is precedent for plumbing such options through in the startup.sh script here.

Why is this needed?

I would like to see this option on ARC runners as well. We have some indiscriminate workflows in our organization that use the self-hosted label only and I would like to offer a runner without the default label set, making its use "opt in" without having to make adjustments to many repositories.

I imagine this would also be useful for all the reasons that it was originally added to the runner config.sh script.

Additional context

It was specifically suggested here to open an issue on this project to get this added.

github-actions[bot] commented 5 months ago

Hello! Thank you for filing an issue.

The maintainers will triage your issue shortly.

In the meantime, please take a look at the troubleshooting guide for bug reports.

If this is a feature request, please review our contribution guidelines.

scoplin commented 5 months ago

PR proposed, but of course contingent on agreeing that this is A) a good idea on a legacy runner enhancement and B) the narrow enablement of the single flag is a reasonable approach.