actions / actions-runner-controller

Kubernetes controller for GitHub Actions self-hosted runners
Apache License 2.0
4.53k stars 1.07k forks source link

Init container logs excessively during copy command #3637

Open schniedergers opened 1 month ago

schniedergers commented 1 month ago

Checks

Controller Version

0.9.2

Deployment Method

Helm

Checks

To Reproduce

1. Create an image that is based on ghcr.io/actions/actions-runner:latest and add `node` to it
2. Use that image as runner image in oci://ghcr.io/actions/actions-runner-controller-charts
3. Observe the logs from the init container. As `node` adds a lot of files, the verbose copy creates thousands of log lines each time a runner starts.

Describe the bug

Not really a bug, but it clogs up the log management (and increases costs)

Describe the expected behavior

Expected is that not every copied file is logged during the init container run.

Additional Context

Removing the `-v` from https://github.com/actions/actions-runner-controller/blob/80d848339e5eeaa6b2cda3c4a5393dfcb4614794/charts/gha-runner-scale-set/templates/_helpers.tpl#L90 reduces the logs significantly.

Controller Logs

-

Runner Pod Logs

Jul 03 15:26:58.148
i-00521ce9880b56851
at-gha-base
'/home/runner/externals/./node20/include/node/openssl/archs/linux-x86_64/no-asm/providers/common/include/prov/der_sm2.h' -> '/home/runner/tmpDir/./node20/include/node/openssl/archs/linux-x86_64/no-asm/providers/common/include/prov/der_sm2.h'

Jul 03 15:26:58.148
i-00521ce9880b56851
at-gha-base
'/home/runner/externals/./node20/include/node/openssl/archs/linux-x86_64/no-asm/providers/common/include/prov/der_rsa.h' -> '/home/runner/tmpDir/./node20/include/node/openssl/archs/linux-x86_64/no-asm/providers/common/include/prov/der_rsa.h'

Jul 03 15:26:58.148
i-00521ce9880b56851
at-gha-base
'/home/runner/externals/./node20/include/node/openssl/archs/linux-x86_64/no-asm/providers/common/include/prov/der_ecx.h' -> '/home/runner/tmpDir/./node20/include/node/openssl/archs/linux-x86_64/no-asm/providers/common/include/prov/der_ecx.h'

Jul 03 15:26:58.148
i-00521ce9880b56851
at-gha-base
'/home/runner/externals/./node20/include/node/openssl/archs/linux-x86_64/no-asm/providers/common/include/prov/der_ec.h' -> '/home/runner/tmpDir/./node20/include/node/openssl/archs/linux-x86_64/no-asm/providers/common/include/prov/der_ec.h'

Jul 03 15:26:58.148
i-00521ce9880b56851
at-gha-base
'/home/runner/externals/./node20/include/node/openssl/archs/linux-x86_64/no-asm/providers/common/include/prov/der_dsa.h' -> '/home/runner/tmpDir/./node20/include/node/openssl/archs/linux-x86_64/no-asm/providers/common/include/prov/der_dsa.h'

Jul 03 15:26:58.148
i-00521ce9880b56851
at-gha-base
'/home/runner/externals/./node20/include/node/openssl/archs/linux-x86_64/no-asm/providers/common/include/prov/der_digests.h' -> '/home/runner/tmpDir/./node20/include/node/openssl/archs/linux-x86_64/no-asm/providers/common/include/prov/der_digests.h'
github-actions[bot] commented 1 month ago

Hello! Thank you for filing an issue.

The maintainers will triage your issue shortly.

In the meantime, please take a look at the troubleshooting guide for bug reports.

If this is a feature request, please review our contribution guidelines.