actions / actions-runner-controller

Kubernetes controller for GitHub Actions self-hosted runners
Apache License 2.0
4.76k stars 1.12k forks source link

ARC not working with an organization whose name ends in hyphen #3663

Open and-es opened 4 months ago

and-es commented 4 months ago

Checks

Controller Version

0.9.3

Deployment Method

Helm

Checks

To Reproduce

Follow Quickstart guide(https://docs.github.com/en/actions/hosting-your-own-runners/managing-self-hosted-runners-with-actions-runner-controller/quickstart-for-actions-runner-controller) with an organization named "camphor-".
githubConfigUrl is "https://github.com/camphor-".

Describe the bug

Failed to create a runner scale set. The controller log says:

"error": "AutoscalingRunnerSet.actions.github.com \"arc-runner-set\" is invalid: metadata.labels: Invalid value: \"camphor-\": a valid label must be an empty string or consist of alphanumeric characters, '-', '_' or '.', and must start and end with an alphanumeric character (e.g. 'MyValue',  or 'my_value',  or '12345', regex used for validation is '(([A-Za-z0-9][-A-Za-z0-9_.]*)?[A-Za-z0-9])?')"}

Describe the expected behavior

Create a runner scale set successfully.

Additional Context

Nothing. I just follow the quickstart guide.

Controller Logs

https://gist.github.com/and-es/1456bf907dd2ddc1716881ce6a2e1224

Runner Pod Logs

No runner pods
github-actions[bot] commented 4 months ago

Hello! Thank you for filing an issue.

The maintainers will triage your issue shortly.

In the meantime, please take a look at the troubleshooting guide for bug reports.

If this is a feature request, please review our contribution guidelines.

and-es commented 4 months ago

I sent PR. Please review it.