Open molson504x opened 1 month ago
Hello! Thank you for filing an issue.
The maintainers will triage your issue shortly.
In the meantime, please take a look at the troubleshooting guide for bug reports.
If this is a feature request, please review our contribution guidelines.
Checks
Controller Version
0.9.3
Deployment Method
Helm
Checks
To Reproduce
Describe the bug
While deploying a runner scale set, I attempted to use the GH App client ID rather than the GH App ID. This produces the following error in the reconciler:
However, per the GH App Docs an App ID and Client ID should both be allowed in the
iss
parameter of a JWT token. Additionally, GitHub seems to be guiding people to use the Client ID for authenticating GH Apps instead of the App ID (messaging such as:appears on the app configuration page).
When I run this with an App ID instead of a Client ID the runner scale set deploys as expected.
Describe the expected behavior
I'd expect the Client ID to be able to be used when deploying a new Runner Scale Set.
Additional Context
Controller Logs
Runner Pod Logs