actions / actions-runner-controller

Kubernetes controller for GitHub Actions self-hosted runners
Apache License 2.0
4.76k stars 1.12k forks source link

Ability to scale up runners with scaleUpFactor option #3694

Open akhilp6 opened 3 months ago

akhilp6 commented 3 months ago

Checks

Controller Version

0.9.3

Deployment Method

Helm

Checks

To Reproduce

Check the in the gha-runner-scale-set chart, there's no way to set `sclaeUpFactor in `values.yaml` for the actions.github.com_autoscalingrunnersets.yaml

Describe the bug

Currently the runners scales up based on the count of jobs requested. For example, let say if we get a 5 new job request then it basically add 5 new runners. This approach is increasing our start up time as it basically queue up until all the runners are started. We would like to have some kind of scaleUpFactor option which would basically pre-load the runners which would help in decreasing the start up time.

Describe the expected behavior

N/A

Additional Context

N/A

Controller Logs

N/A

Runner Pod Logs

N/A
xunholy commented 1 week ago

@akhilp6 how does this differ from minRunners? Is the idea you'd always create slightly more than the queue depth on Github?