actions / actions-runner-controller

Kubernetes controller for GitHub Actions self-hosted runners
Apache License 2.0
4.76k stars 1.12k forks source link

Chart - Enable Custom Annotations and Labels for AutoscalingRunnerSet #3722

Open omerap12 opened 2 months ago

omerap12 commented 2 months ago

What would you like added?

Currently, there is no option to add custom annotations or labels to the AutoscalingRunnerSet. I would like to request the addition of this feature.

Why is this needed?

This feature would allow us to apply our own annotations or labels, such as the "karpenter do-not-evict" annotation, enabling more granular control and customization.

Additional context

Add any other context or screenshots about the feature request here.

github-actions[bot] commented 2 months ago

Hello! Thank you for filing an issue.

The maintainers will triage your issue shortly.

In the meantime, please take a look at the troubleshooting guide for bug reports.

If this is a feature request, please review our contribution guidelines.

omerap12 commented 2 months ago

Just to clarify, I would like the option to add labels to the AutoscalingRunnerSet, which will propagate to the pods it creates.

4c74356b41 commented 1 week ago

how is this not a thing? nobody is using these at all? thats one of the top things any1 would require

4c74356b41 commented 1 week ago

@omerap12 hey, this might help you

kuhnroyal commented 4 days ago

I would like to add the dependabot label to my RunnerSet so that I can enable dependabot on self-hosted runners: https://docs.github.com/en/code-security/dependabot/working-with-dependabot/managing-dependabot-on-self-hosted-runners