actions / actions-runner-controller

Kubernetes controller for GitHub Actions self-hosted runners
Apache License 2.0
4.6k stars 1.09k forks source link

"Chart version" does not contain the appropriate version #3744

Open kizuna-cloud opened 1 week ago

kizuna-cloud commented 1 week ago

Checks

Controller Version

0.9.3

Deployment Method

Helm

Checks

To Reproduce

1. get an image of "gha-runner-scale-set controller" from the following site and manage it in my cloud

https://hub.docker.com/r/summerwind/actions-runner-controller/tags

2. confirm boot with ArgoCD, pod is stable of "gha-runner-scale-set controller"

3. then build manifest file for B as follows, but error log is detected

    - path: .
      repoURL: ghcr.io/actions
      targetRevision: 0.9.3
      chart: actions-runner-controller-charts/gha-runner-scale-set
      helm:
        values: |
          githubConfigUrl: https://github.com/XXXXXXXXX/YYYYYYYYYYYYYYYYYYYY
          githubConfigSecret: SECRETS
          maxRunners: 2
          minRunners: 1
          controllerServiceAccount:
            namespace: NAMESPACE
            name: "gha-runner-scale-set-controller"
          containerMode:
            type: "kubernetes"
            kubernetesModeWorkVolumeClaim:
              accessModes: ["ReadWriteOnce"]
              storageClassName: "dynamic-blob-storage"
              resources:
                requests:
                  storage: 1Gi
          template:
            spec:
              serviceAccountName: XXXXXXXXXXXXXXXXXXXXX-runner
              containers:
                - name: runner
                  image: "XXXXXXXXXXXXXXXXXXXXXXXXX"
                  command: ["/home/runner/run.sh"]

Apart from the above question, I would like to get the latest image of "gha-runner-scale set". 
Where should I get it from? if you have image that are officially provided, please share url

Describe the bug

YYYY-MM-DDTHH:MM:SSZ    INFO    AutoscalingRunnerSet    Autoscaling runner set version doesn't match the build version. Deleting the resource.  {"version": "gha-runner-scale-set-0.9.3", "autoscalingrunnerset": {"name":"gha-runner-scale-set","namespace":"NAMESPACE"}, "targetVersion": "gha-runner-scale-set-0.9.3", "actualVersion": "0.9.3"}

Checked Controller Logs and found the above log, so determined that the label in AutoscalingRunnerSet is incorrectly set.

Describe the expected behavior

I cloned the officially provided chart to my local environment and modified the Chart version as follows

charts/gha-runner-scale-set/Chart.yaml

appVersion: "0.9.3"
↓
appVersion: "gha-ruuner-scale-set-0.9.3"

The helm template command was executed and the following label was corrected

app.kubernetes.io/version=0.9.3
↓
app.kubernetes.io/version=gha-ruuner-scale-set-0.9.3

I don't plan to install Helm Chart locally, so I need to know what to do about it.

Additional Context

values: |
          githubConfigUrl: https://github.com/XXXXXXXXX/YYYYYYYYYYYYYYYYYYYY
          githubConfigSecret: SECRETS
          maxRunners: 2
          minRunners: 1
          controllerServiceAccount:
            namespace: NAMESPACE
            name: "gha-runner-scale-set-controller"
          containerMode:
            type: "kubernetes"
            kubernetesModeWorkVolumeClaim:
              accessModes: ["ReadWriteOnce"]
              storageClassName: "dynamic-blob-storage"
              resources:
                requests:
                  storage: 1Gi
          template:
            spec:
              serviceAccountName: XXXXXXXXXXXXXXXXXXXXX-runner
              containers:
                - name: runner
                  image: "XXXXXXXXXXXXXXXXXXXXXXXXX"
                  command: ["/home/runner/run.sh"]

Controller Logs

YYYY-MM-DDTHH:MM:SSZ    INFO    AutoscalingRunnerSet    Autoscaling runner set version doesn't match the build version. Deleting the resource.  {"version": "gha-runner-scale-set-0.9.3", "autoscalingrunnerset": {"name":"gha-runner-scale-set","namespace":"NAMESPACE"}, "targetVersion": "gha-runner-scale-set-0.9.3", "actualVersion": "0.9.3"}


### Runner Pod Logs
no runner pod is created - no events
github-actions[bot] commented 1 week ago

Hello! Thank you for filing an issue.

The maintainers will triage your issue shortly.

In the meantime, please take a look at the troubleshooting guide for bug reports.

If this is a feature request, please review our contribution guidelines.