actions / actions-runner-controller

Kubernetes controller for GitHub Actions self-hosted runners
Apache License 2.0
4.76k stars 1.12k forks source link

Controller fails to install with google config sync because a cluster scoped resource includes a namespace #3774

Closed rogermadsen closed 1 month ago

rogermadsen commented 1 month ago

Checks

Controller Version

0.23.7

Deployment Method

Helm

Checks

To Reproduce

Install controller using Google config sync.

It will fail with the and error saying that cluster scoped resources can not have a namespace.

Describe the bug

The below role binding should not include a namespace if it's a cluster role binding.

https://github.com/actions/actions-runner-controller/blob/master/charts/actions-runner-controller/templates/manager_role_binding_secrets.yaml

This is blocking us from installing this controller using Google config sync, which is strict on not allowing namespaces on cluster scoped resource. Unlike kubectl or helm which will just ignore the namespace.

I have a fix ready for this that I can contribute.

This is google config sync:

https://github.com/GoogleContainerTools/kpt-config-sync

Available as a managed service on Google Kubernetes Engine.

Describe the expected behavior

Installing controller with google config sync should be successful.

Additional Context

No logs.

Controller Logs

No logs.

Runner Pod Logs

No logs.
github-actions[bot] commented 1 month ago

Hello! Thank you for filing an issue.

The maintainers will triage your issue shortly.

In the meantime, please take a look at the troubleshooting guide for bug reports.

If this is a feature request, please review our contribution guidelines.

rogermadsen commented 1 month ago

I'm closing this one again. Seems like this controller is or is about to be depricated? We switched to gha-runner-scale-set-controller which is working fine.