Too many requeues during CleanupResources

[pulkitanz]

Checks

• [X] I've already read https://docs.github.com/en/actions/hosting-your-own-runners/managing-self-hosted-runners-with-actions-runner-controller/troubleshooting-actions-runner-controller-errors and I'm sure my issue is not covered in the troubleshooting guide.
• [X] I am using charts that are officially provided

Controller Version

0.9.3

Deployment Method

Other

Checks

• [X] This isn't a question or user support case (For Q&A and community support, go to Discussions).
• [X] I've read the Changelog before submitting this issue and I'm sure it's not due to any recently-introduced backward-incompatible changes

To Reproduce

Very easy to reproduce if you have even one local pod running you can check the logs of creation and deletion.

Describe the bug

There's this function to cleanup resources in the ARC controller https://github.com/actions/actions-runner-controller/blob/master/controllers/actions.github.com/ephemeralrunner_controller.go#L137-L144 now this is requeued in the case when the function returns done as false. Now the mess up is that every time this function is called it does this Delete Pod Return false and requeue Next Queue catch up Delete Jitconfig Secret Return false and requeue Next Queue catch up Return true

Why are we requeing it so many times is what I don't understand, why not delete the pod and the jitconfig secret in the same reconcile.

Describe the expected behavior

The amount of requeues here is slowing down our runner termination process.

Additional Context

-

Controller Logs

-

Runner Pod Logs

-

[github-actions[bot]]

Hello! Thank you for filing an issue.

The maintainers will triage your issue shortly.

In the meantime, please take a look at the troubleshooting guide for bug reports.

If this is a feature request, please review our contribution guidelines.