actions / actions-runner-controller

Kubernetes controller for GitHub Actions self-hosted runners
Apache License 2.0
4.78k stars 1.13k forks source link

EphemeralRunner `status.ready` should reflect Pod readiness #3823

Open ordovicia opened 1 week ago

ordovicia commented 1 week ago

Checks

Controller Version

0.9.3

Deployment Method

Other

Checks

To Reproduce

N/A

Describe the bug

EphemeralRunner's readiness (status.ready field) is calculated as follows. It becomes true when the associated Pod starts running (status.phase: Running).

https://github.com/actions/actions-runner-controller/blob/8b36ea90ebe81710fcdcb4f96424b43203d24f1e/controllers/actions.github.com/ephemeralrunner_controller.go#L701

However, EphemeralRunner's readiness should reflect the Pod's readiness (status.conditions[type="Ready"].status). Otherwise, an EphemeralRunner is recognized as ready while its Pod is actually not ready yet.

Describe the expected behavior

EphemeralRunners become ready once their associated Pods become ready, not just running.

Additional Context

N/A

Controller Logs

N/A

Runner Pod Logs

N/A
github-actions[bot] commented 1 week ago

Hello! Thank you for filing an issue.

The maintainers will triage your issue shortly.

In the meantime, please take a look at the troubleshooting guide for bug reports.

If this is a feature request, please review our contribution guidelines.