search

actions / attest

Action for generating attestations for workflow artifacts
MIT License
32 stars 5 forks source link

Timeout in OCI push #91

Closed matthiasfehr closed 4 months ago

matthiasfehr commented 4 months ago

When using the action actions/attest-build-provenance with the option push-to-registry enabled, I regularly got a timeout error.

Digging into the action I discovered that the timeout corresponding to the OCI push is set here to 2 seconds, which is obviously pretty low and not every registry can fulfil the request in this time, especially not ones which are backed by an object storage.

May I ask here to increase the timeout to something more usual like e.g 30s?

For the time being, is there any possible workaround until this gets fixed?

bdehamer commented 4 months ago

@matthiasfehr I've got a fix queued up and will try to get this deployed today.

Out of curiosity, which OCI registry are you using?

matthiasfehr commented 4 months ago

I'm running a self implemented OCI registry which can handle different storage backends, e.g. with the filesystem storage backend the operations are fast enough and the action succeeds without issues, but with the S3 backend it often takes a bit more than 2 seconds and therefore the action times out. It took me quite some time to figure out that the problem was the unusually low timeout of this action, so fixing it may prevent also others of breaking their heads over it.