Fix zstd not being used after zstd version upgrade to 1.5.4 on hosted runners

actions / cache

Cache dependencies and build outputs in GitHub Actions

MIT License

4.45k stars 1.18k forks source link

Fix zstd not being used after zstd version upgrade to 1.5.4 on hosted runners #1118

Closed lvpx closed 1 year ago

lvpx commented 1 year ago

Description

This PR adds changes to fix zstd not being used after zstd version upgrade to 1.5.4 on hosted runners. Please see this PR in actions/toolkit for changes.

Motivation and Context

Fixes #1110 Fixes #1114 Potentially fixes #1116

How Has This Been Tested?

Tested with all hosted runners using workflows and ensured all test cases pass on CI.

Screenshots (if appropriate):

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation (add or update README or docs)

Checklist:

[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

kduret commented 1 year ago

I confirm this fixed my issue good job @pdotl

DerTim1 commented 1 year ago

@pdotl Can you please tag that version and also move tag v3 to this release?

lvpx commented 1 year ago

@DerTim1 I have tagged the version and moved it to v3.

chetbox commented 1 year ago

I re-ran a job that was failing, which seems to have picked up a newer of action/cache@v3, but I am still having the same problem.

Download action repository 'actions/cache@v3' (SHA:95b455a0fba5a5e1770cc10ded51e5fe99a6737b)

Error: Failed to restore cache entry. Exiting as fail-on-cache-miss is set

I tried again with actions/cache@69d9d449aced6a2ede0bc19182fadc3a0a42d2b0 and it worked.

@pdotl it looks to me like the v3 tag needs to be moved to 69d9d449aced6a2ede0bc19182fadc3a0a42d2b0?

lvpx commented 1 year ago

@chetbox fixed! 👍

chetbox commented 1 year ago

Thanks @pdotl, looks good now. Much appreciated.

atsju commented 1 year ago

I had this problem first time today after the fix : Download action repository 'actions/cache@v3' (SHA:69d9d449aced6a2ede0bc19182fadc3a0a42d2b0) Cache not found for input keys: Windows-mingw810_64 https://github.com/atsju/DFTFringe/actions/runs/4233014638/jobs/7353437839 And the cache existed. Are caches supposed to be invalidated automatically when the action is updated ?

vmarkovtsev commented 1 year ago

Our CI has started to fail after the new release. It looks like either some or all files are not restored from the cache now. Example. The same cache worked on a different runner: link. We tried to drop all the caches. That didn't help.

cdce8p commented 1 year ago

Are caches supposed to be invalidated automatically when the action is updated ?

That is expected. You'll need to rebuild all caches with v3.2.6. That's because now the action correctly looks for zstd caches if it is installed and only if not falls back to the glib defaults. Over the last few days the zstd version parsing was broken which caused only glib caches to be created.