search

actions / cache

Cache dependencies and build outputs in GitHub Actions
MIT License
4.39k stars 1.17k forks source link

`Cache save failed.` should include the name of the cache and the failure class #1213

Open jsoref opened 1 year ago

jsoref commented 1 year ago

https://github.com/check-spelling/almalinux-wiki/actions/runs/5655212720

Annotations

1 warning Check Spelling Cache save failed.

  1. Users shouldn't have to click the not particularly obvious link to determine which cache failed (especially given that the link doesn't actually expand the log and getting to the thing once you're at the log is a PITA).
  2. It would be nice if already exists was included in the annotation

For reference, the log does have the information available, so including it in the ::warning ::output would not be hard.

2023-07-25T09:46:19.6142161Z [command]/usr/bin/tar --posix -cf cache.tzst --exclude cache.tzst -P -C /home/runner/work/almalinux-wiki/almalinux-wiki --files-from manifest.txt --use-compress-program zstdmt
2023-07-25T09:46:19.8054484Z Failed to save: Unable to reserve cache with key check-spelling-dictionaries-a:ce53902f1052602f8f1fe328d65ace5561a1e8c1-29b2bbcc31edb0dd98b0a3ab90fa2e1d8f6d67b2, another job may be creating this cache. More details: Cache already exists. Scope: refs/heads/spell-check-with-spelling, Key: check-spelling-dictionaries-a:ce53902f1052602f8f1fe328d65ace5561a1e8c1-29b2bbcc31edb0dd98b0a3ab90fa2e1d8f6d67b2, Version: 3c9138c5df6ff04e024d625faac2cacce774cfddeb89e911df030b9c6871f016
2023-07-25T09:46:19.8100252Z ##[warning]Cache save failed.

Expected results

::warning ::Failed to save cache `check-spelling-dictionaries-a:ce53902f1052602f8f1fe328d65ace5561a1e8c1-29b2bbcc31edb0dd98b0a3ab90fa2e1d8f6d67b2` -- cache already exists
github-actions[bot] commented 5 months ago

This issue is stale because it has been open for 200 days with no activity. Leave a comment to avoid closing this issue in 5 days.

jsoref commented 5 months ago

I stand by this issue