actions / cache

Cache dependencies and build outputs in GitHub Actions
MIT License
4.49k stars 1.2k forks source link

Updated to actions/cache@v4, but that does not stop the Node16 warning on v3 #1323

Closed bernhardkaindl closed 1 month ago

bernhardkaindl commented 7 months ago

https://github.com/xenserver/status-report/actions/runs/7802115676

This workflow (you can check the workflow file in the job itself) is upgraded actions/cache@v4, but that does not stop the warning about @v3...:

Python3: Pre-Commit Suite
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
ThabetAmer commented 7 months ago

+1 same here having actions/cache@v4

ruigomesbioinf commented 6 months ago

+1 same here

joshmgross commented 2 months ago

This warning is coming from a composite action in your workflow

      - uses: pre-commit/action@v3.0.0
        name: Run pre-commit checks
        with:
          # Show the output of the commands for the problem matcher, see above.
          extra_args: --all-files --verbose
        env:
          PYTHONDEVMODE: yes  # Enable Python3 checks. See the comment above.
          # Skip the no-commit-to-branch check inside of GitHub CI (for CI on merge to master)
          SKIP: no-commit-to-branch

https://github.com/pre-commit/action/issues/189

I'd recommend updating to the latest version of that action - https://github.com/pre-commit/action/releases/tag/v3.0.1

https://github.com/xenserver/status-report/blob/master/.github/workflows/main.yml#L176

If anyone else is experiencing this issue, I'd recommend checking all of the actions your workflow depends on.