actions / cache

Cache dependencies and build outputs in GitHub Actions
MIT License
4.36k stars 1.16k forks source link

Restore action doesn't actually fail workflow even when fail-on-cache-miss is true #1369

Open efine-vivodyne opened 3 months ago

efine-vivodyne commented 3 months ago

If your issue is relevant to this repository, please delete this text and continue to create this issue. Thank you in advance.

I'm using v4.0.0 of the Restore action, and I've noticed consistently that if there's a cache miss, that the step of the workflow errors, but it does not fail the job/workflow

I get this all the time Error: Failed to restore cache entry. Exiting as fail-on-cache-miss is set.

But then the job proceeds just fine and after it's done I see a checkmark in the "workflow summary" page for that job.

I would expect that it should fail the job right at that step as soon as the cache miss occurs

deemp commented 3 months ago

It seems like this problem was fixed in https://github.com/actions/cache/releases/tag/v4.0.2.

efine-vivodyne commented 3 months ago

It seems like this problem was fixed in https://github.com/actions/cache/releases/tag/v4.0.2.

Thanks! I'll try that