search

actions / cache

Cache dependencies and build outputs in GitHub Actions
MIT License
4.36k stars 1.16k forks source link

This action is lacking maintenance #1401

Open IanButterworth opened 1 month ago

IanButterworth commented 1 month ago

PRs are not being reviewed nor is their CI is being run.

Please add support to https://github.com/orgs/community/discussions/121811 or raise the issue if you know a better way.

Gabrielpereira765 commented 1 month ago

Ooo

Gabrielpereira765 commented 1 month ago

0000oo

Gabrielpereira765 commented 1 month ago

Gostei

DilumAluthge commented 1 month ago

The CODEOWNERS file in this repo suggests that maybe we should ping the @actions/actions-cache team.

https://github.com/actions/cache/blob/0c45773b623bea8c8e75f6c82b208c3cf94ea4f9/.github/CODEOWNERS#L1-L1

DilumAluthge commented 1 month ago

Hmmm. It seems that I'm not able to ping the @actions/actions-cache team.

bearfriend commented 3 weeks ago

What is going on? Any kind of information at all as to why there is no maintenance of any kind in this repo for many months would be helpful. Sorry for the ping and thanks.

@andrejusk @bryanmacfarlane @cheshire137 @chrispat @DanRigby @dhadka @GrantBirki @joshmgross @marzvrover @mikhailkoliada @nikola-jokic @philip-gai @pje @rentziass @TingluoHuang

IanButterworth commented 3 weeks ago

I filed a GitHub support ticket earlier this week and got back

After review of the Community entry, I've reached out to our development teams internally providing the entry as well as the associated open PRs for further review. I'll update you as I learn more and thank you in advance for your patience.

joshmgross commented 3 weeks ago

👋 Hey everyone,

Just a quick update - your concerns have been heard and I'm working on getting a proper response.

This action is still being supported by GitHub, but I totally understand the concern around the lack of timely responses on issues and pull requests. If there are any urgent bug fixes or security issues, please let me know and I'll make sure they're prioritized.

IanButterworth commented 3 weeks ago

Thanks @joshmgross

Part of the pain of not having prompt maintenance attention is that because CI is set to run on approval for new contributors PRs like https://github.com/actions/cache/pull/1325 take a lot longer to actually be tested and contributers get fatigued.

It's a bigger discussion, but I hope that either someone can stay on top of promptly running CI for new contributions, or that setting is disabled.

joshmgross commented 3 weeks ago

That makes sense @IanButterworth, thanks for sharing your perspective.

I'd recommend testing changes locally or within workflows on a fork to validate them - that's going to be a much faster feedback loop than waiting on someone to approve runs on a pull request.

We cannot disable that setting at this time, it's necessary to prevent abusive actors from running arbitrary workflows on our repositories.

IanButterworth commented 3 weeks ago

Not being able to disable the setting is understandable, but the fact that CI still hasn't been run on https://github.com/actions/cache/pull/1325 really illustrates the issue. The submitter stated that tests pass locally for them, but no response.

I guess I don't understand what's going wrong here. Enough noise has been made by myself and others, I believe.

joshmgross commented 3 weeks ago

I was made of aware of #1325 on Thursday and reviewed it then asking for another test case. I'm still following up internally to see if there's a better option than the hard-coded output that's mixed in with user-provided outputs from all existing steps.

As for the current status of this action and what we can do to improve here from a community perspective, I'm still working on that internally and don't have anything more to share at this time.

IanButterworth commented 3 weeks ago

I do appreciate your efforts. Thanks