Remove Unused `process.exit(1)` Call

actions / configure-pages

An action to enable Pages and extract various metadata about a site. It can also be used to configure various static site generators we support as starter workflows.

https://pages.github.com

MIT License

148 stars 56 forks source link

Remove Unused `process.exit(1)` Call #141

Closed threeal closed 6 months ago

threeal commented 7 months ago

This pull request refactor the main function in the src/index.js file by removing call to the process.exit(1) function because of the following reason:

Call to the core.setFailed function already set the exit code of the action to 1.
The main function will exit anyway so there's no need to exit immediately by using the process.exit function.

JamesMGreene commented 6 months ago

Thank you for your contribution! We appreciate your interest in helping us make this action better. 🙇🏻 💝

While both of your statements are optimistically true, we have found that there are specific scenarios within GitHub Actions where having this forced process.exit() invocation can prevent Node.js process hangups. Much safer for our consumers if we leave it intact. 🦺