search

actions / create-github-app-token

GitHub Action for creating a GitHub App Installation Access Token
https://github.com/marketplace/actions/create-github-app-token
MIT License
365 stars 53 forks source link

feat(inputs): permissions #111

Closed ragnarpa closed 4 months ago

gr2m commented 7 months ago

We don't want to implement permissions as a single object, but as separate keys, as described here: https://github.com/actions/create-github-app-token/issues/3

We want these keys to be automatically kept up to date based on new releases of https://github.com/octokit/app-permissions, which we can implement via actions and https://github.com/apps/octokit-release-notifier

ragnarpa commented 7 months ago

We don't want to implement permissions as a single object, but as separate keys, as described here: #3

We want these keys to be automatically kept up to date based on new releases of https://github.com/octokit/app-permissions, which we can implement via actions and https://github.com/apps/octokit-release-notifier

@gr2m, when can we expect #3 to be released?

gr2m commented 7 months ago

we should be unblocked since https://github.com/octokit/app-permissions/releases/tag/v2.0.0

martincostello commented 5 months ago

Any chance on this being released soon if it's unblocked? I'd like to consume the changes to move into this action from a third-party one.

gr2m commented 5 months ago

sorry we have been busy with other projects, I cannot give you an ETA when we get to finish up this work. The current pull request cannot be merged as is, my concerns from above (https://github.com/actions/create-github-app-token/pull/111#issuecomment-1975373214) have not been addressed yet. We don't want a single permissions parameter, but separate permission_{permission_name} keys, e.g. permission_issues. And we want these to be auto-generated based on https://github.com/octokit/app-permissions/

ragnarpa commented 4 months ago

Hi all. Sorry, but I do not have enough resources to address the aforementioned concerns in this pull request. As this pull won't me merged as it is then I'll close it.