search

actions / create-github-app-token

GitHub Action for creating a GitHub App Installation Access Token
https://github.com/marketplace/actions/create-github-app-token
MIT License
321 stars 46 forks source link

Description for owner input is confusing #116

Closed martincostello closed 4 months ago

martincostello commented 4 months ago

I'm looking to migrate to this action from peter-murray/workflow-application-token-action (currently waiting on #111 for feature parity) and I found the documentation for the owner input confusing:

https://github.com/actions/create-github-app-token/blob/f2acddfb5195534d487896a656232b016a682f3c/action.yml#L22-L24

To me, the documentation implies that this should be the owner of the GitHub app itself, whereas if you trace through the code it's actually the owner for which the GitHub app is installed (i.e. the place you want to give the app access to).

https://github.com/actions/create-github-app-token/blob/f2acddfb5195534d487896a656232b016a682f3c/lib/main.js#L112-L129

gr2m commented 4 months ago

the owner for which the GitHub app is installed

that is correct. Sorry for the confusion. We should definitely update the input description. Pull request welcome!

create-app-token-action-releaser[bot] commented 4 months ago

:tada: This issue has been resolved in version 1.9.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: