Support Client ID as an alternative input to Client Secret

actions / create-github-app-token

GitHub Action for creating a GitHub App Installation Access Token

https://github.com/marketplace/actions/create-github-app-token

MIT License

321 stars 46 forks source link

Support Client ID as an alternative input to Client Secret #136

Open cloudshiftchris opened 2 months ago

cloudshiftchris commented 2 months ago

GitHub now recommends using the clientId instead of the appId/privateKey

Augment the options to allow clientId/clientSecret, validating that either this pair or appId/privateKey are provided, and pass these options along in the call to createAppAuth.

gr2m commented 2 months ago

Just to clarify, you cannot use the Client Secret, the private key is still required. But the OAuth Client ID is now recommended to be used as a substitute to the numeric app ID for github.com, and probably GitHub Enterprise Server 3.14+

We just shipped support for passing the client ID to Octokit's app authentication strategy: https://github.com/octokit/auth-app.js/releases/tag/v7.1.0