search

actions / create-github-app-token

GitHub Action for creating a GitHub App Installation Access Token
https://github.com/marketplace/actions/create-github-app-token
MIT License
321 stars 46 forks source link

post-action warning on revoke failure in case token already expired #140

Closed danra closed 1 month ago

danra commented 1 month ago

I'm seeing the following warning in the post job cleanup step:

Post job cleanup.
Warning: Token revocation failed: Bad credentials - https://docs.github.com/rest

Probably because the token was already invalidated, because the job took more than 1h to run (see https://github.com/actions/create-github-app-token/issues/121).

No issue here other than there shouldn't be any warning in this case.

gr2m commented 1 month ago

We do already check for expiration time, maybe we got it implemented wrong though? https://github.com/actions/create-github-app-token/blob/c8f55efbd427e7465d6da1106e7979bc8aaee856/lib/post.js#L24-L28

dboriichuk commented 1 month ago

I just want to +1 to this issue. It happens in jobs, which runs for several hours.

gr2m commented 1 month ago

thanks for letting us know @dboriichuk. That suggests that our expiration check is not working. I'll add more logs to get to the bottom of it

create-app-token-action-releaser[bot] commented 1 month ago

:tada: This issue has been resolved in version 1.10.2 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: