Open scootafew opened 3 months ago
GitHub apps use two different types of authentication
GET /app
or to create the installation access tokensSo the request that creates the token won't include the rite rate limit in its response, but revoking the access token will. Or we could log both 🤷
making a dedicated request to
https://api.github.com/rate_limit
in this action to fetch this info
If that's information you need, it would be simple enough to just do so in an additional step, e.g. with run: gh api rate_limit
Right I see, that does make sense. I guess logging it in the post
step could still be useful.
I can of course add a dedicated step to do this, I was just wondering if I could avoid adding that logic everywhere, since I use this action in quite a lot of jobs... and I thought it could be useful for others too.
I would have been tempted to create a wrapper action which called this one and implemented that logic but from what I remember composite actions don't support post
steps
Can you explain the problem it would solve if we logged rate limits?
I'm not sure if it would be worth making a dedicated request to
https://api.github.com/rate_limit
in this action to fetch this info, but I am assuming the API calls for token issuance/revocation return the usual rate limit headers? If so it would be nice to log these so that users can see the value ofx-ratelimit-remaining
for the authenticated app.