actions / create-github-app-token

GitHub Action for creating a GitHub App Installation Access Token
https://github.com/marketplace/actions/create-github-app-token
MIT License
344 stars 47 forks source link

feat: Add a `skip_token_revoke` input for configuring token revocation #54

Closed smockle closed 11 months ago

smockle commented 11 months ago

Fixes https://github.com/actions/create-github-app-token/issues/55

Currently, actions/create-github-app-token always/unconditionally revokes the installation access token in a post step, at the completion of the current job. This prevents tokens from being used in other jobs.

This PR makes this behavior configurable:

This PR adds a test for the skip-token-revoke: "true" case.

This is configurable in other app token actions, e.g. tibdex/github-app-token and wow-actions/use-app-token.

[^1]: Note that "false" is also truthy: Boolean("false") is true. If we think that’ll potentially confuse folks, I can require skip-token-revoke to be set explicitly to "true".

gr2m commented 11 months ago

I've seen this option but couldn't think of a use case for it. Do you know why it was added to tibdex/github-app-token or can you think of a use case when someone would need it?

No biggie but could you create an issue next time before putting in work into a pull request? That way we can have a discussion and avoid unnecessary work

smockle commented 11 months ago

I've seen this option but couldn't think of a use case for it…can you think of a use case when someone would need it?

No biggie but could you create an issue next time before putting in work into a pull request? That way we can have a discussion and avoid unnecessary work

@gr2m I opened https://github.com/actions/create-github-app-token/issues/55, and I wrote about our use case there. Let’s move discussion there.

create-app-token-action-releaser[bot] commented 11 months ago

:tada: This PR is included in version 1.4.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: