actions / create-release

An Action to create releases via the GitHub Release API
MIT License
1.33k stars 297 forks source link

Question: Is this supposed to work for creating releases of GitHub Actions found in Marketplace? #40

Open localheinz opened 4 years ago

localheinz commented 4 years ago

I have successfully used actions/create-release to create releases for libraries here on GitHub.

Today I have built a GitHub Action that I have - so far manually - released to GitHub Marketplace.

It appears that creating a release for GitHub Actions published to the GitHub Marketplace is currently not supported, is that right?

Here's the corresponding workflow:

# https://help.github.com/en/categories/automating-your-workflow-with-github-actions

name: "Continuous Deployment"

on:
  push:
    branches:
      - "master"
    tags:
      - "**"

jobs:
  continuous-deployment:
    name: "Continuous Deployment"

    runs-on: "ubuntu-latest"

    env:
      DOCKER_IMAGE: "ergebnis/composer-root-version-action"
      DOCKER_USERNAME: "ergebnis"

    steps:
      - name: "Checkout"
        uses: "actions/checkout@v2.0.0"

      - name: "Build Docker image"
        run: "docker build --tag ${{ env.DOCKER_IMAGE }}:latest ."

      - name: "Docker Login"
        if: "'refs/heads/master' == github.ref || startsWith(github.ref, 'refs/tags/')"
        run: "echo ${{ secrets.DOCKER_PASSWORD }} | $(which docker) login --password-stdin --username ${{ env.DOCKER_USERNAME }}"

      - name: "Push Docker image (latest)"
        if: "'refs/heads/master' == github.ref || startsWith(github.ref, 'refs/tags/')"
        run: "docker push ${{ env.DOCKER_IMAGE }}:latest"

      - name: "Determine tag"
        if: "startsWith(github.ref, 'refs/tags/')"
        id: "determine-tag"
        run: "echo \"::set-output name=tag::${GITHUB_REF#refs/tags/}\""

      - name: "Tag Docker image (versioned)"
        if: "startsWith(github.ref, 'refs/tags/')"
        run: "docker tag ${{ env.DOCKER_IMAGE }} ${{ env.DOCKER_IMAGE }}:${{ steps.determine-tag.outputs.tag }}"

      - name: "Push Docker image (versioned)"
        if: "startsWith(github.ref, 'refs/tags/')"
        run: "docker push ${{ env.DOCKER_IMAGE }}:${{ steps.determine-tag.outputs.tag }}"

      - name: "Docker Logout"
        if: "'refs/heads/master' == github.ref || startsWith(github.ref, 'refs/tags/')"
        run: "docker logout"

      - name: "Create release"
        if: "startsWith(github.ref, 'refs/tags/')"
        uses: "actions/create-release@v1.0.0"
        env:
          GITHUB_TOKEN: "${{ secrets.ERGEBNIS_BOT_TOKEN }}"
        with:
          draft: false
          prerelease: false
          release_name: "${{ steps.determine-tag.outputs.tag }}"
          tag_name: "${{ steps.determine-tag.outputs.tag }}"

which currently fails with

Screen Shot 2020-02-06 at 20 09 35

💁‍♂ For an example, see https://github.com/ergebnis/composer-root-version-action/runs/430394008?check_suite_focus=true.

davidkarlsen commented 4 years ago

+1 - anything we can do to get marketplace support? Now I need to go in and update the release and save it to get published to marketplace.