search

actions / dependency-review-action

A GitHub Action for detecting vulnerable dependencies and invalid licenses in your PRs
MIT License
596 stars 103 forks source link

fix: getRefs function to handle merge_group events #766

Closed louis-bompart closed 2 months ago

louis-bompart commented 5 months ago

Fixes #456

Essentially, put https://github.com/actions/dependency-review-action/issues/456#issuecomment-1537840047 in the code.

To the best of my knowledge, this should work, because a merge_group event is a PullRequestEvent I think.

louis-bompart commented 4 months ago

👋 @elireisman, sorry for the poke; I was hoping to get a review on this 😶. I think it's a quick win ;) Feel free to redirect me to someone else if I'm barking at the wrong tree 😄 Thanks!

louis-bompart commented 4 months ago

Thanks 🙌 I saw 47a6b35 :x: on https://github.com/actions/dependency-review-action/actions/runs/8933751781/job/24923072522 I'm assuming this was caused by my branch being a few commits behind main, so I rebased my branch onto main with 92ca1f7

elireisman commented 4 months ago

👋 I think you need to update the PR one more time prior to re-review (see the check-dist entry)

louis-bompart commented 4 months ago

👋 I think you need to update the PR one more time prior to re-review (see the check-dist entry)

My bad! I missed the npm run package 😅 before committing. Should be fixed in e7e99e1

nachtgold commented 2 months ago

Hi @elireisman do you know another possible reviewer than @pcarlisle?

elireisman commented 2 months ago

👋 @nachtgold @louis-bompart apologies - looks like there wasn't time for anyone to circle back to this yet.

Looks like we need one more dist update (npm run package) pushed to the PR to get it updated before we can move forward. Unfortunately, if I check out the branch and do that myself, I won't be able to review the PR either 😄

louis-bompart commented 2 months ago

@elireisman :shipit: 😄