search

actions / dependency-review-action

A GitHub Action for detecting vulnerable dependencies and invalid licenses in your PRs
MIT License
558 stars 94 forks source link

Fix the max comment length issue #767

Closed jhutchings1 closed 3 weeks ago

jhutchings1 commented 1 month ago

I ran into #730 in a demo I was building, so I threw together a quick fix for the issue. Now it'll generate a minimum comment. It's not super elegant (a bit of code duplication), but I was in a hurry to unblock the demo. I don't mind if the team decides to make some tweaks to make this less duplicative.

Fixes #730

Screenshot 2024-05-06 at 10 43 34 AM
cameron-wellthy commented 1 month ago

@jhutchings1 can I help get this merged? we're starting to see this happen with dependency-review frequently.

jhutchings1 commented 1 month ago

This was enough to unblock my demos, but I would love for the team to take this across the line if you have cycles. @bteng22, happy for an assist here!

Justin Hutchings | Senior Director of Product Management | GitHub - Security | https://www.github.com/jhutchings1 https://www.linkedin.com/in/hutchingsjustin/ https://www.linkedin.com/in/hutchingsjustin/

On Wed, May 15, 2024 at 11:05 PM Cameron Cooper @.***> wrote:

@jhutchings1 https://github.com/jhutchings1 can I help get this merged? we're starting to see this happen with dependency-review frequently.

— Reply to this email directly, view it on GitHub https://github.com/actions/dependency-review-action/pull/767#issuecomment-2112938634, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADCCCIYSVZNBWD3OK26B7OLZCOBUTAVCNFSM6AAAAABHIFIIC2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJSHEZTQNRTGQ . You are receiving this because you were mentioned.Message ID: @.***>

elireisman commented 3 weeks ago

Update

I think this should be ready for review cc @hmaurer @bteng22 🙇

elireisman commented 3 weeks ago

👍 @bteng22 let me know what you think - I committed your suggestion, if this is looking right to you I can update the dist/ packaging and ping you for a re-stamp?

EDIT: updated, let me know what you think of the changes 👍