search

actions / deploy-pages

GitHub Action to publish artifacts to GitHub Pages for deployments
https://pages.github.com
MIT License
662 stars 78 forks source link

CNAME file doesn't work to set custom domain #304

Open scriptype opened 9 months ago

scriptype commented 9 months ago

Hi, I'm actually not sure if this is the right place for this issue, but here it is.

I've recently switched the pages setting of my repository to use github actions:

image

When I was using the "deploy from a branch" option, GitHub was automatically seeing the cname file in the docs folder (pages folder) to set up custom domain. This was useful because the file was being automatically generated based on static site generator configuration.

I have noticed this cname file is no longer useful since I switched to using actions/deploy-pages. It would be sweet if cname file just worked like before, or alternatively, if the action had an input for cname.

Just to be clear, the problem is having to enter the custom domain by hand in the github pages settings UI when using actions/deploy-pages.

EvanCarroll commented 3 days ago

I had the same problem having uploaded a CNAME file, here was my solution https://devops.stackexchange.com/a/19892/18965