search

actions / deploy-pages

GitHub Action to publish artifacts to GitHub Pages for deployments
https://pages.github.com
MIT License
671 stars 79 forks source link

Value 'github-pages' is not valid #344

Closed ioquatix closed 3 months ago

ioquatix commented 6 months ago

Not sure why this happens, but looks like the schema validation in VSCode reports this error:

image

It's a little confusing as I believe this is actually correct.

yoannchaudet commented 6 months ago

Cannot see the whole workflow in the screenshot but GitHub Pages does not really own the VS code extension anyway.

Would you mind asking in https://github.com/orgs/community/discussions/categories/actions?discussions_q=is%3Aunanswered+category%3AActions?

ioquatix commented 6 months ago

It would be this one https://github.com/socketry/async/blob/main/.github/workflows/documentation.yaml which I use across multiple projects.

I suppose there must be a schema for this file, defined by VSCode, which doesn't take into account GitHub pages...

ioquatix commented 6 months ago

I found the schema and created an issue ☝🏼

NicoWeio commented 5 months ago

Just to stress: This means that the example code from this action's README yields a linting error. I just filed a crude PR upstream (https://github.com/actions/languageservices/pull/80).

NicoWeio commented 5 months ago

Whoa, looks like our efforts were totally misdirected.

Apparently, the GitHub Actions extension performs a lookup for existing environments in one's repo and complains about any non-existing ones, even though the workflow might run fine and just create one. See https://github.com/github/vscode-github-actions/issues/215.

yoannchaudet commented 3 months ago

Closing this issue because it is not actionable from that Action.