search

actions / download-artifact

MIT License
1.44k stars 495 forks source link

[feat req] Option not to fail if no files were downloaded #352

Open remyroy opened 2 months ago

remyroy commented 2 months ago

What would you like to be added?

This is related to #311 . It seems like our workflow now fails if there is no artifact to download or no artifact found. We would like an option for it not to fail or similar to upload-artifact, an option like if-no-artifact-found to choose how to treat this in the configuration.

This is a recent run with 'actions/download-artifact@v4' (SHA:fa0a91b85d4f404e444e00e005971372dc801d16) that failed: https://gist.github.com/remyroy/4895a06a4c72baa6ea4f55539c4f8f56 from our workflow on https://github.com/eth-educators/ethstaker-deposit-cli/blob/main/.github/workflows/comment.yml . This full run can be found on https://github.com/eth-educators/ethstaker-deposit-cli/actions/runs/10889396462 .

Why is this needed?

In our case, we sometimes generate artifacts based on the state of a pull request. If no artificat is generated, we don't want to fail and instead, we want to silently continue.

rrundle-dave commented 2 weeks ago

+1. There are a couple of check-if-artifact-exists actions floating around when this could just be handled by the official action. The upload-artifact action has a if-no-file-found option for treatment and, as mentioned, there could be a similar option here.