search

actions / github-script

Write workflows scripting the GitHub API in JavaScript
MIT License
4.24k stars 424 forks source link

Avoid setting `baseUrl` to undefined when input is not provided #439

Closed joshmgross closed 1 year ago

joshmgross commented 1 year ago

Fixes #436

Replaces #437

Due to how options are passed through @actions/github to Octokit, an undefined baseUrl prevents the default from being used. This breaks using github-script on GHES, which requires the GHES instance API URL.

437 attempted to reproduce this issue in a test, but it was unsuccessful. There's a similar issue in the integration test, but the fix doesn't work despite it being confirmed in https://github.com/actions/github-script/issues/436#issuecomment-1816670425.

I've included the other integration tests, but they don't cover this specific scenario or what we're trying to fix.

github-actions[bot] commented 1 year ago

Hello from actions/github-script! (52c67b9f485fe926d70f2427d49a877b08c6f2c2)

BellaBijl commented 4 months ago

Het was heel erg gezellig bij de buren