actions / heroku

GitHub Action for interacting with Heroku
MIT License
178 stars 62 forks source link

[Issue] Unable to build actions/heroku@1.0.0 #11

Open Necromos opened 4 years ago

Necromos commented 4 years ago

Hello! First of all thank you for this great action!

Recently (since today) we have stumbled upon an error which breaks our CD workflow.

It looks like Docker image on which Heroku action is dependant (node:10-slim) got updated yesterday and since then it updates dependant packages during build sequence:

Reading state information...
The following package was automatically installed and is no longer required:
  xz-utils
Use 'apt autoremove' to remove it.
The following additional packages will be installed:
  libcurl3 libffi6 libgmp10 libgnutls30 libgssapi-krb5-2 libhogweed4 libidn11
  libidn2-0 libk5crypto3 libkeyutils1 libkrb5-3 libkrb5support0 libldap-2.4-2
  libldap-common libnettle6 libnghttp2-14 libp11-kit0 libpsl5 librtmp1
  libsasl2-2 libsasl2-modules-db libssh2-1 libssl1.0.2 libtasn1-6
  libunistring0
Suggested packages:
  gnutls-bin krb5-doc krb5-user
Recommended packages:
  ca-certificates krb5-locales publicsuffix libsasl2-modules
The following NEW packages will be installed:
  curl libcurl3 libffi6 libgmp10 libgnutls30 libgssapi-krb5-2 libhogweed4
  libidn11 libidn2-0 libk5crypto3 libkeyutils1 libkrb5-3 libkrb5support0
  libldap-2.4-2 libldap-common libnettle6 libnghttp2-14 libp11-kit0 libpsl5
  librtmp1 libsasl2-2 libsasl2-modules-db libssh2-1 libssl1.0.2 libtasn1-6
  libunistring0
0 upgraded, 26 newly installed, 0 to remove and 0 not upgraded.

Which results unfortunately with

Processing triggers for libc-bin (2.24-11+deb9u4) ...
curl: (77) error setting certificate verify locations:
  CAfile: /etc/ssl/certs/ca-certificates.crt
  CApath: /etc/ssl/certs
The command '/bin/sh -c apt-get update && apt-get -y --no-install-recommends install curl   && curl -fsSLO https://download.docker.com/linux/static/stable/x86_64/docker-${DOCKERVERSION}.tgz   && tar xzvf docker-${DOCKERVERSION}.tgz --strip 1                  -C /usr/local/bin docker/docker   && rm docker-${DOCKERVERSION}.tgz   && rm -rf /var/lib/apt/lists/*   && yarn global add heroku' returned a non-zero code: 77

Any help would be highly appreciated! :)

sjdonado commented 4 years ago

Hi, you can replace actions/heroku@1.0.0 by sjdonado/heroku@master as a temp fix until the pull request is merged

andrejromanov commented 4 years ago

From my pov it would be great to use full version number of node image in Dockerfile For example: 10.18.0-slim It'll help to reduce unexpected problems with dependencies

halftheopposite commented 4 years ago

I am facing the exact same issue as @Necromos on node:10.16.3-alpine:

Processing triggers for libc-bin (2.24-11+deb9u4) ...
curl: (77) error setting certificate verify locations:
  CAfile: /etc/ssl/certs/ca-certificates.crt
  CApath: /etc/ssl/certs
The command '/bin/sh -c apt-get update && apt-get -y --no-install-recommends install curl   && curl -fsSLO https://download.docker.com/linux/static/stable/x86_64/docker-${DOCKERVERSION}.tgz   && tar xzvf docker-${DOCKERVERSION}.tgz --strip 1                  -C /usr/local/bin docker/docker   && rm docker-${DOCKERVERSION}.tgz   && rm -rf /var/lib/apt/lists/*   && yarn global add heroku' returned a non-zero code: 77

Thank you very much for the action you provided so far, it has greatly helped me.

EDIT: Using sjdonado/heroku@master seems to do the work.

Necromos commented 4 years ago

From my pov it would be great to use full version number of node image in Dockerfile For example: 10.18.0-slim It'll help to reduce unexpected problems with dependencies

Agree, that would be the best way to go in my opinion. Also there could be done a simple image from base linux distribution for better control but that would be quite an overkill

sjdonado commented 4 years ago

From my pov it would be great to use full version number of node image in Dockerfile For example: 10.18.0-slim It'll help to reduce unexpected problems with dependencies

Agree, that would be the best way to go in my opinion. Also there could be done a simple image from base linux distribution for better control but that would be quite an overkill

You are right, I already update my pr changing the node base image to node:10.18-stretch-slim