search

actions / http-client

A lightweight HTTP client optimized for use with actions, TypeScript with generics and async await.
https://github.com/features/actions
Other
72 stars 33 forks source link

prettier rules #20

Closed bryanmacfarlane closed 4 years ago

bryanmacfarlane commented 4 years ago

After rules merged, contributor will run prettier and enable (uncomment the lines in the workflow)

bryanmacfarlane commented 4 years ago

As pointed out in the review of #16, the PR changing all the lines is not viable to review by a core contributor. It forces the contributor to review every line in the project and compare against rules that weren't part of the PR. What should have been part of the PR (the rules, package.json, workflow changes and package scripts) were not part of the PR and what was in the PR is not really usable. I need a core contributor to actually run the format and for the CI to validate it.

However thanks for creating the issue. Creating an issue prior to the PR with a discussion on the rules would have avoided the unnecessary work. Hope that helps.