search

actions / http-client

A lightweight HTTP client optimized for use with actions, TypeScript with generics and async await.
https://github.com/features/actions
Other
72 stars 33 forks source link

Fix noproxy conventions #49

Open andrewstuart opened 3 years ago

andrewstuart commented 3 years ago

Looks like we're not the first to notice this. This PR should address #40. :smile:

andrewstuart commented 3 years ago

@andymckay, any chance you could take a look at this? :pleading_face:

andrewstuart commented 3 years ago

Or @bryanmacfarlane ? Since Andy appears to be on vacation. :grin:

andrewstuart commented 3 years ago

@andymckay, any chance we could get this reviewed? It's going to turn into a rather large problem for our team working behind corporate firewalls and proxies if we have to maintain a list of all hosts we need actions to communicate with.

andrewstuart commented 3 years ago

Still hoping to see this merged. I can definitely say delays for something small but important like this are going to be a huge factor in what I push for in large enterprises I work for in the future. Especially when GitLab is actively writing blog posts about this, clearly doing some research: https://about.gitlab.com/blog/2021/01/27/we-need-to-talk-no-proxy/